Skip to content

ui: fix display host hypervisorversion#5301

Merged
DaanHoogland merged 1 commit intoapache:4.15from
shapeblue:fix-ui-hostdisplay-hypervisorversion
Aug 11, 2021
Merged

ui: fix display host hypervisorversion#5301
DaanHoogland merged 1 commit intoapache:4.15from
shapeblue:fix-ui-hostdisplay-hypervisorversion

Conversation

@shwstppr
Copy link
Contributor

Description

Fixes #5294

Do not display host version as hypervisor version

Code in old UI was not showing host version as hypervisor version


                                dataProvider: function (args) {
                                    $.ajax({
                                        url: createURL("listHosts&id=" + args.context.hosts[0].id),
                                        dataType: "json",
                                        async: true,
                                        success: function (json) {
                                            var item = json.listhostsresponse.host[0];
                                            if (item && item.outofbandmanagement) {
                                                item.powerstate = item.outofbandmanagement.powerstate;
                                            }

                                            if (!item.hypervisorversion && item.details && item.details["Host.OS"]) {
                                                item.hypervisorversion =  item.details["Host.OS"] + " " +  item.details["Host.OS.Version"];
                                            }

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Fixes apache#5294

Do not display host version as hypervisor version

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5301 (SL-JID-503)

Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvazquez
Copy link
Contributor

@davidjumani @utchoang can you please review?

Copy link

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DaanHoogland DaanHoogland merged commit fb0dedc into apache:4.15 Aug 11, 2021
@DaanHoogland DaanHoogland deleted the fix-ui-hostdisplay-hypervisorversion branch August 11, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hosts details page showing incorrect data for Hypervisor Version

6 participants